From c38e89d3f1bf04b51a0ed6cc650f03f0fc43c77a Mon Sep 17 00:00:00 2001
From: Juan Pablo Vial <jpvialb@incoviba.cl>
Date: Tue, 5 Aug 2025 15:41:23 -0400
Subject: [PATCH] FIX: Telefono sobre rango maximo de integer en MySQL

---
 ...03_change_telefono_size_in_propietario.php | 26 +++++++++++++++++
 app/resources/views/ventas/add.blade.php      |  2 +-
 app/src/Service/Valor.php                     | 10 ++++++-
 app/src/Service/Valor/Phone.php               | 28 +++++++++++++++++++
 app/src/Service/Venta/Propietario.php         | 18 +++++++++---
 5 files changed, 78 insertions(+), 6 deletions(-)
 create mode 100644 app/resources/database/migrations/20250805192903_change_telefono_size_in_propietario.php
 create mode 100644 app/src/Service/Valor/Phone.php

diff --git a/app/resources/database/migrations/20250805192903_change_telefono_size_in_propietario.php b/app/resources/database/migrations/20250805192903_change_telefono_size_in_propietario.php
new file mode 100644
index 0000000..54a7f08
--- /dev/null
+++ b/app/resources/database/migrations/20250805192903_change_telefono_size_in_propietario.php
@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+use Phinx\Migration\AbstractMigration;
+
+final class ChangeTelefonoSizeInPropietario extends AbstractMigration
+{
+    /**
+     * Change Method.
+     *
+     * Write your reversible migrations using this method.
+     *
+     * More information on writing migrations is available here:
+     * https://book.cakephp.org/phinx/0/en/migrations.html#the-change-method
+     *
+     * Remember to call "create()" or "update()" and NOT "save()" when working
+     * with the Table class.
+     */
+    public function change(): void
+    {
+        $this->table('propietario')
+            ->changeColumn('telefono', 'biginteger', ['null' => true, 'signed' => false, 'default' => null])
+            ->update();
+    }
+}
diff --git a/app/resources/views/ventas/add.blade.php b/app/resources/views/ventas/add.blade.php
index e870736..c8aa737 100644
--- a/app/resources/views/ventas/add.blade.php
+++ b/app/resources/views/ventas/add.blade.php
@@ -156,7 +156,7 @@
     <script>
         const regiones = [
             @foreach ($regiones as $region)
-            '<div class="item" data-value="{{$region->id}}">{{$region->descripcion}}</div>',
+            '<div class="item" data-value="{{$region->id}}">{{$region->numeral}} - {{$region->descripcion}}</div>',
             @endforeach
         ]
 
diff --git a/app/src/Service/Valor.php b/app/src/Service/Valor.php
index 7789e84..1454611 100644
--- a/app/src/Service/Valor.php
+++ b/app/src/Service/Valor.php
@@ -4,7 +4,7 @@ namespace Incoviba\Service;
 use DateTimeInterface;
 use DateTimeImmutable;
 use DateMalformedStringException;
-use function PHPUnit\Framework\countOf;
+use Incoviba\Service\Valor\Phone;
 
 class Valor
 {
@@ -40,6 +40,14 @@ class Valor
         }
         return $value / $this->ufService->get($date);
     }
+    public function phone(): Phone
+    {
+        return new Phone();
+    }
+    public function telefono(): Phone
+    {
+        return $this->phone();
+    }
 
     protected function getDateTime(null|string|DateTimeInterface $date): DateTimeInterface
     {
diff --git a/app/src/Service/Valor/Phone.php b/app/src/Service/Valor/Phone.php
new file mode 100644
index 0000000..3fc4eec
--- /dev/null
+++ b/app/src/Service/Valor/Phone.php
@@ -0,0 +1,28 @@
+<?php
+namespace Incoviba\Service\Valor;
+
+class Phone
+{
+    public function toDatabase(?string $phone): ?int
+    {
+        if ($phone === null) {
+            return null;
+        }
+        return (int) str_replace([' ', '+'], '', $phone) ?? null;
+    }
+    public function toDisplay(?int $phone): ?string
+    {
+        if ($phone === null) {
+            return null;
+        }
+        $parts = preg_split('/(?=<country>\d{2})?(?=<area>\d)(?=<first>\d{4})(?=<last>\d{4})/', $phone);
+        $output = [];
+        if (array_key_exists('country', $parts)) {
+            $output [] = "+{$parts[0]}";
+        }
+        $output [] = $parts[1] ?? '';
+        $output [] = $parts[2] ?? '';
+        $output [] = $parts[3] ?? '';
+        return implode(' ', $output);
+    }
+}
diff --git a/app/src/Service/Venta/Propietario.php b/app/src/Service/Venta/Propietario.php
index 9ea89e5..cec026b 100644
--- a/app/src/Service/Venta/Propietario.php
+++ b/app/src/Service/Venta/Propietario.php
@@ -1,22 +1,24 @@
 <?php
 namespace Incoviba\Service\Venta;
 
+use PDOException;
+use Psr\Log\LoggerInterface;
 use Incoviba\Common\Ideal\Service;
 use Incoviba\Common\Implement\Exception\EmptyResult;
 use Incoviba\Exception\ServiceAction\Create;
 use Incoviba\Exception\ServiceAction\Read;
 use Incoviba\Exception\ServiceAction\Update;
-use Incoviba\Repository;
 use Incoviba\Model;
-use PDOException;
-use Psr\Log\LoggerInterface;
+use Incoviba\Repository;
+use Incoviba\Service\Valor;
 
 class Propietario extends Service
 {
     public function __construct(
         LoggerInterface $logger,
         protected Repository\Venta\Propietario $propietarioRepository,
-        protected Repository\Direccion $direccionRepository
+        protected Repository\Direccion $direccionRepository,
+        protected Valor $valorService
     ) {
         parent::__construct($logger);
     }
@@ -49,6 +51,9 @@ class Propietario extends Service
             $data['direccion'] = $direccion->id;
         }
         $filteredData = $this->propietarioRepository->filterData($data);
+        if (array_key_exists('telefono', $filteredData)) {
+            $filteredData['telefono'] = $this->valorService->telefono()->toDatabase($filteredData['telefono']);
+        }
         try {
             return $this->propietarioRepository->edit($propietario, $filteredData);
         } catch (PDOException | EmptyResult $exception) {
@@ -85,6 +90,10 @@ class Propietario extends Service
         ]);
         $filtered_data = array_intersect_key($data, $fields);
 
+        if (array_key_exists('telefono', $filtered_data)) {
+            $filtered_data['telefono'] = $this->valorService->telefono()->toDatabase($filtered_data['telefono']);
+        }
+
         try {
             $propietario = $this->propietarioRepository->fetchById($data['rut']);
             $edits = [];
@@ -95,6 +104,7 @@ class Propietario extends Service
         } catch (EmptyResult) {
             try {
                 $propietario = $this->propietarioRepository->create($filtered_data);
+                $this->logger->info('Propietario', ['propietario' => $propietario]);
                 $propietario = $this->propietarioRepository->save($propietario);
             } catch (PDOException $exception) {
                 throw new Create(__CLASS__, $exception);